Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Whitelist dlls for Windows package #803

Merged
merged 2 commits into from May 29, 2015
Merged

Whitelist dlls for Windows package #803

merged 2 commits into from May 29, 2015

Conversation

martyngigg
Copy link
Member

Fixes trac issue #11857

Tester
This only affects the Windows installer. Please download the built package and test that it installs successfully and MantidPlot runs. You should see that it is now ~40Mb smaller.

The release notes were updated here

@martyngigg
Define a list of third party dlls to deploy
b9e1b20 
This will avoid accidentally dropping something into the repository
and having it automatically included in the package.
Refs #11857
@martyngigg
Clean up the formatting.
2ee5638 
Refs #11857
@martyngigg martyngigg added High Priority An issue or pull request that if not addressed is severe enough to postponse a release. Maintenance Unassigned issues to be addressed in the next maintenance period. labels May 28, 2015
@martyngigg martyngigg added this to the Release 3.5 milestone May 28, 2015
@martyngigg
Copy link
Member Author

The doc tests failure is just the unreliable DownloadFile failure and not related to these changes.

@FedeMPouzols FedeMPouzols self-assigned this May 29, 2015
@FedeMPouzols
Copy link
Contributor

DownloadFileTest strikes back, but the package has been built successfully on isis-ndw1490 and should be there (unless it is removed after the doc-test failure). Is there any way to get it? I can't find anything through the Jenkins Workspace etc.

I noticed that CPack is taking over 10 minutes even after these changes.

@FedeMPouzols
Copy link
Contributor

Oh sorry, now I can see it. But it seems to be around 181 MB:
http://builds.mantidproject.org/job/pull_requests-win7/956/

@martyngigg
Copy link
Member Author

I see what has happened now. My test build didn't include the documentation, which actually accounts for the 40Mb :(
Despite this, I think the changes are still worthwhile as it will prevent new dlls that are added the the Third Party from being included unless they are specifically requested.

@FedeMPouzols
Copy link
Contributor

The win64 package installs well, and I could not see any issues that should have been obvious if there was anything wrong with the dlls. So let's merge it in. This should produce cleaner installations and also a smaller package even if the gain cannot be that big.

The release notes will need an update if it's not feasible to shrink the package that much.

FedeMPouzols added a commit that referenced this pull request May 29, 2015
@FedeMPouzols
Merge pull request #803 from mantidproject/11857_whitelist_win_packag…
5c744fa 
…e_dlls

Whitelist dlls for Windows package
@FedeMPouzols FedeMPouzols merged commit 5c744fa into master May 29, 2015
@FedeMPouzols FedeMPouzols deleted the 11857_whitelist_win_package_dlls branch May 29, 2015 11:21
@martyngigg
Copy link
Member Author

Good point. I'll update the notes to remove the entry as it's now more of a maintenance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@FedeMPouzols FedeMPouzols

Labels
High Priority An issue or pull request that if not addressed is severe enough to postponse a release. Maintenance Unassigned issues to be addressed in the next maintenance period.
Projects
None yet
Milestone
Release 3.5
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@martyngigg @FedeMPouzols