New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ConvertUnits in EnginXFitPeaks #847
Use ConvertUnits in EnginXFitPeaks #847
Conversation
…its_in_EnginXFitPeaks This comes with the docs-test fixes so now it should be more likely to get the ok flag from all CI platforms
…its_in_EnginXFitPeaks Conflicts: Code/Mantid/Framework/PythonInterface/plugins/algorithms/EnginXFitPeaks.py Fix merge conflict over more informative message added in another branch, re #10587
There's currently one pylint issue in this branch that will go away with PR #810 (which refactors PyExec in EnginXFitPeaks.py), so I'll wait for that one. |
After merging with the other branch (#847), which had refactored the PyExec code, pylint is now happy about the number of variables per method, and I think this is ready to be tested. When this one is finished, my plan is to go ahead with #11749 next, which will refactor code in several algorithms. After that there's 2-3 tickets that need a bit of clarification from scientists but that should not be lenghty, and we would be in a good position to do the first basic GUI. The old trac umbrella ticket where we have all the pending issues is now the tick list of this issue: #9213. |
…EnginXFitPeaks Use ConvertUnits in EnginXFitPeaks
Use convert unit where mantid currently supports this. clear code and added documentation |
Fixes #11429. I also expanded a bit the documentation of CreateWorkspace, to explain how ParentWorkspace is used.
To test:
Relase notes: as with other EnginX issues at the moment I'm not adding anything, as this is very much work in progress.