Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ConvertUnits in EnginXFitPeaks #847

Merged
merged 11 commits into from Jun 18, 2015

Conversation

FedeMPouzols
Copy link
Contributor

Fixes #11429. I also expanded a bit the documentation of CreateWorkspace, to explain how ParentWorkspace is used.

To test:

  • Tests should pass. The changes are unit/system/doc tested.
  • Code review.

Relase notes: as with other EnginX issues at the moment I'm not adding anything, as this is very much work in progress.

@FedeMPouzols FedeMPouzols added Python Diffraction Issues and pull requests related to diffraction labels Jun 3, 2015
@FedeMPouzols FedeMPouzols added this to the Release 3.5 milestone Jun 3, 2015
…its_in_EnginXFitPeaks

This comes with the docs-test fixes so now it should be more likely to get the ok flag from all CI platforms
…its_in_EnginXFitPeaks

Conflicts:
	Code/Mantid/Framework/PythonInterface/plugins/algorithms/EnginXFitPeaks.py

Fix merge conflict over more informative message added in another branch, re #10587
@FedeMPouzols
Copy link
Contributor Author

There's currently one pylint issue in this branch that will go away with PR #810 (which refactors PyExec in EnginXFitPeaks.py), so I'll wait for that one.

@FedeMPouzols
Copy link
Contributor Author

After merging with the other branch (#847), which had refactored the PyExec code, pylint is now happy about the number of variables per method, and I think this is ready to be tested.

When this one is finished, my plan is to go ahead with #11749 next, which will refactor code in several algorithms. After that there's 2-3 tickets that need a bit of clarification from scientists but that should not be lenghty, and we would be in a good position to do the first basic GUI. The old trac umbrella ticket where we have all the pending issues is now the tick list of this issue: #9213.

Anders-Markvardsen added a commit that referenced this pull request Jun 18, 2015
…EnginXFitPeaks

Use ConvertUnits in EnginXFitPeaks
@Anders-Markvardsen Anders-Markvardsen merged commit 6bce843 into master Jun 18, 2015
@Anders-Markvardsen Anders-Markvardsen deleted the 10587_use_ConvertUnits_in_EnginXFitPeaks branch June 18, 2015 11:02
@Anders-Markvardsen
Copy link
Member

Use convert unit where mantid currently supports this. clear code and added documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Diffraction Issues and pull requests related to diffraction
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use the convertUnits algorithm in EnginX FitPeaks
2 participants