Feature/10530 pre cut md #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needed to expose a few more property types to get this started. All tested.
Particular focus on projection inputs. Also started adding binning information.
Also needed to expose columnnames properly via ITableWorskpace
Use binning boundaries as extents if they define inner limit. Otherwise the original dimension boundaries are used as extents. In either case, the extents need to be transformed into the new basis.
The tests are right, but the implementation is wrong. We should calculate all extents in the new basis first, then figure out the most conservative of those to use for the actual extents used in BinMD/SliceMD.
This wan't right first time round.
I want to get the key parts of this in. The python algorithm can relatively safely be added later.
|
test this please |
Python lists are printed with different spacing so things shifted slightly when using a list for getColumnNames Refs #10530
|
It looks as if the final commit has not been pushed to the branch on github. Trac sees a commit that has made it to develop but is not on this branch. A simple |
|
This branch is fine. I added a few more commits to this branch in preparation to adding the actual algorithm so that I could rebase onto Master when these changes go through. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes trac issue #10530
Changes required to the python framework to allow CutMD to be brought in. This is a separation of the high-risk changes from the low-risk ones. CutMD itself is a low risk change.