Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pyinstaller wont build on linux #1894

Closed
samtygier-stfc opened this issue Aug 7, 2023 · 0 comments · Fixed by #1895
Closed

Pyinstaller wont build on linux #1894

samtygier-stfc opened this issue Aug 7, 2023 · 0 comments · Fixed by #1895
Assignees
@samtygier-stfc
Labels
Type: Bug

Comments

@samtygier-stfc
Copy link
Collaborator

Summary

We hit python/cpython#88227 in PackageWithPyInstaller.py

In python 3.10 pkgutil.walk_packages() fails if the path is a pathlib.Path on linux

Steps To Reproduce

Run PackageWithPyInstaller.py

Expected Behaviour

Builds package

Current Behaviour

AttributeError: 'PosixPath' object has no attribute 'startswith'

Context

Current main. Probably since switching to python 3.10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samtygier-stfc samtygier-stfc

Labels
Type: Bug
Projects
Mantid Imaging Work
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix python 3.10 walk_packages needing a str not a path mantidproject/mantidimaging
1 participant
@samtygier-stfc