Move Gaussian Operation to Use compute_function Style #2060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notes added moved np to type check
samtygier-stfc
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Move operations to compute_function style #2051
Description
The project aims to standardize how operations are executed, moving away from using the partial function style towards a more structured compute_function approach. A new static method compute_function has been introduced in gaussian.py. This method the core logic for applying the Gaussian filter directly on a per-slice basis. This modification ensures a clear separation between the setup and execution phases of the operation.
Documentation
not done yet
How have you changed the documentation to reflect your changes? All changes should be noted in the appropriate file in docs/release_notes