Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mypy to 1.8 #2100

Merged
merged 1 commit into from
Mar 6, 2024
Merged

Update mypy to 1.8 #2100

merged 1 commit into from
Mar 6, 2024

Conversation

samtygier-stfc
Copy link
Collaborator

@samtygier-stfc samtygier-stfc commented Mar 4, 2024

Issue

Step before #2008

Description

Update mypy package before doing type annotation work for #2008

Testing & Acceptance Criteria

Automated tests should pass

Create a fresh mantidimaging-dev environment and run make mypy

mamba activate base
python ./setup.py create_dev_env
mamba activate mantidimaging-dev

Documentation

Will put release notes when #2008 is complete

@samtygier-stfc samtygier-stfc marked this pull request as ready for review March 4, 2024 17:14
@coveralls
Copy link

Coverage Status

coverage: 74.392%. remained the same
when pulling 7de6ac3 on 2008-update-mypy
into 6fce472 on main.

@JackEAllen JackEAllen added this pull request to the merge queue Mar 6, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 6, 2024
@JackEAllen JackEAllen added this pull request to the merge queue Mar 6, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 6, 2024
@samtygier-stfc samtygier-stfc added this pull request to the merge queue Mar 6, 2024
Merged via the queue into main with commit ae17b19 Mar 6, 2024
8 checks passed
@samtygier-stfc samtygier-stfc deleted the 2008-update-mypy branch March 6, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants