Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ruff to 0.3.2 #2118

Merged
merged 4 commits into from
Mar 11, 2024
Merged

Update ruff to 0.3.2 #2118

merged 4 commits into from
Mar 11, 2024

Conversation

samtygier-stfc
Copy link
Collaborator

@samtygier-stfc samtygier-stfc commented Mar 8, 2024

Issue

Close #2114

Description

Update to ruff 0.3.1 0.3.2

Use ruff check to avoid deprecation warning

Remove deprecated numpy random calls. Note this was not picked up in #2038 because of a ruff bug

Testing

Update dev environment and run make mypy

Documentation

Release notes

@samtygier-stfc samtygier-stfc marked this pull request as ready for review March 8, 2024 17:05
@coveralls
Copy link

coveralls commented Mar 8, 2024

Coverage Status

coverage: 74.385%. remained the same
when pulling 6d7ce95 on 2114-update-ruff
into 589ecfc on main.

Use unit_test_helper function to avoid duplication. Note this was not picked up in #2038 because of a ruff bug.

Fix seeds, because we don't need the randomness
@samtygier-stfc samtygier-stfc changed the title Update ruff to 0.3.1 Update ruff to 0.3.2 Mar 11, 2024
@JackEAllen JackEAllen self-requested a review March 11, 2024 11:02
@JackEAllen JackEAllen added this pull request to the merge queue Mar 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 11, 2024
@JackEAllen JackEAllen added this pull request to the merge queue Mar 11, 2024
Merged via the queue into main with commit b95aebb Mar 11, 2024
8 checks passed
@JackEAllen JackEAllen deleted the 2114-update-ruff branch March 11, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Ruff and enable more checkers
3 participants