Fix pep 585 and 604 (ruff UP006, UP007) issues #2124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samtygier-stfc
force-pushed
the
2117-ruff-rules-up006
branch
from
b8f7494
to
a0bd8d3
Compare
samtygier-stfc
changed the title
JackEAllen
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Part of #2117
Description
For typing standard containers, use the new generic syntax, not the typing module versions. Use
|notation instead ofOptionalandUnionOld methods are deprecated.
Commit generated using Ruff's auto fix
Testing & Acceptance Criteria
make ruffand
make mypyShould pass
Documentation
Not needed yet