Enhanced Image Stack Loading and Operation Handling for Flat-fielding Tests #2176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samtygier-stfc
requested changes
May 16, 2024
samtygier-stfc
requested changes
May 28, 2024
Comment on lines
105
to
106
| if dark_before is None and dark_after is None: | ||
| raise ValueError("Missing stack: dark_before or dark_after is required for 'Both, concatenated'") |
There was a problem hiding this comment.
This should be inside the if use_dark: a few lines below. Otherwise its check for dark even when its not needed.
Also should be or, because if either is missing it is a problem.
Comment on lines
129
to
130
| else: | ||
| dark_avg = np.zeros_like(flat_avg) |
There was a problem hiding this comment.
Can the multiple dark_avg = np.zeros_like(flat_avg) stay outside the big if statement, so that its only needed once.
samtygier-stfc
requested changes
Jun 7, 2024
There was a problem hiding this comment.
This working and looking good. A few small changes to avoid adding print statements.
Also this will need a rebase once #2215 is merged.
samtygier-stfc
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Conditional Loading: The load_image_stack function has been modified to conditionally load flat and dark images along with the main image stack if the test case is for "Flat-fielding".
FilenameGroup Integration: Utilizes FilenameGroup for managing file paths and ensuring that required files (e.g., log files, flat, and dark images) are correctly loaded.
Enhanced Parameter Handling: Parameters for the operations are dynamically updated to include loaded flats and darks which are essential for "Flat-fielding".
Testing
Flat-fielding with Complete Data: All required flats and darks are specified and available. The function should correctly load these images and use them in the operation.
Acceptance Criteria
Run tests using both "Flat-fielding" and other operations to ensure the function reacts appropriately.
Specifically, test with missing files for "Flat-fielding" to see that the function handles errors as expected.
Integration Check: Confirm that changes do not disrupt the existing setup and integrate cleanly with the current test suite