-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recon Slice Naming #2207
Recon Slice Naming #2207
Conversation
756817b
to
c2b0875
Compare
7ab497b
to
0ff490e
Compare
ff51a9e
to
92cd103
Compare
92cd103
to
0ddd9e4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Completed the functional testing and reviewed the code. One small change requested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CIL_PDHG-TV: The hyphen between PDHG and TV indicates that TV is a configuration of the PDHG algorithm, with CIL representing the library. Therefore, using an underscore would be less appropriate.
Issue
Closes #2206
Description
Modify recon output name to include if it is a slice, the algorithm name and filter name if a filter is available
Testing
Acceptance Criteria
How should the reviewer test your changes?
Documentation
How have you changed the documentation to reflect your changes? All changes should be noted in the appropriate file in docs/release_notes
docs/release_notes/next/feature-2206-recon_file_naming