Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recon Slice Naming #2207

Merged
merged 6 commits into from
Jun 5, 2024
Merged

Recon Slice Naming #2207

merged 6 commits into from
Jun 5, 2024

Conversation

JackEAllen
Copy link
Collaborator

Issue

Closes #2206

Description

Modify recon output name to include if it is a slice, the algorithm name and filter name if a filter is available

Testing

  • Reconstruct multiple individual slices with the same algorithm and filter
  • Reconstruct slices with varying algorithms and filters and verify in the main window that names are easy to compare
  • Reconstruct volume with the same algorithm and filter twice
  • Reconstruct volumes with varying algorithms and filters and verify in the main window that names are easy to compare

Acceptance Criteria

How should the reviewer test your changes?

  • Reconstructed slices follow the naming convention: Recon_slice__
  • Reconstructed volumes follow the naming convention: Recon_Vol__
  • If a filter is not present, not filter is added to filename

Documentation

How have you changed the documentation to reflect your changes? All changes should be noted in the appropriate file in docs/release_notes

docs/release_notes/next/feature-2206-recon_file_naming

@coveralls
Copy link

coveralls commented May 16, 2024

Coverage Status

coverage: 72.75% (+0.02%) from 72.735%
when pulling 0ddd9e4 on recon_Slice_naming
into 4d2ef3e on main.

@JackEAllen JackEAllen marked this pull request as ready for review May 16, 2024 10:18
@JackEAllen JackEAllen self-assigned this May 16, 2024
mantidimaging/gui/windows/recon/presenter.py Outdated Show resolved Hide resolved
mantidimaging/gui/windows/recon/presenter.py Outdated Show resolved Hide resolved
@JackEAllen JackEAllen force-pushed the recon_Slice_naming branch 7 times, most recently from 756817b to c2b0875 Compare May 29, 2024 13:22
@JackEAllen JackEAllen force-pushed the recon_Slice_naming branch 17 times, most recently from 7ab497b to 0ff490e Compare May 30, 2024 10:19
@JackEAllen JackEAllen force-pushed the recon_Slice_naming branch 4 times, most recently from ff51a9e to 92cd103 Compare May 30, 2024 14:45
@ashmeigh ashmeigh self-requested a review June 4, 2024 14:54
@ashmeigh ashmeigh self-assigned this Jun 4, 2024
Copy link
Collaborator

@ashmeigh ashmeigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Completed the functional testing and reviewed the code. One small change requested.

mantidimaging/core/reconstruct/cil_recon.py Show resolved Hide resolved
mantidimaging/gui/windows/recon/view.py Show resolved Hide resolved
@JackEAllen JackEAllen requested a review from ashmeigh June 5, 2024 09:40
Copy link
Collaborator

@ashmeigh ashmeigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CIL_PDHG-TV: The hyphen between PDHG and TV indicates that TV is a configuration of the PDHG algorithm, with CIL representing the library. Therefore, using an underscore would be less appropriate.

@JackEAllen JackEAllen enabled auto-merge June 5, 2024 12:20
@JackEAllen JackEAllen added this pull request to the merge queue Jun 5, 2024
Merged via the queue into main with commit 6c294c1 Jun 5, 2024
8 checks passed
@JackEAllen JackEAllen deleted the recon_Slice_naming branch June 5, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Recon Slice Naming
4 participants