-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply ShutterCount Normalisation Correction when ShutterCounts Available #2214
Merged
+184
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2646d79
to
60feb2f
Compare
9bb53e4
to
7bbb210
Compare
4dadb02
to
a2f2b7a
Compare
samtygier-stfc
requested changes
Jun 17, 2024
cf04793
to
c30f808
Compare
samtygier-stfc
requested changes
Jun 19, 2024
c30f808
to
10749f1
Compare
samtygier-stfc
approved these changes
Jun 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good. I have tested with a few extra print statements to see the normalisation happening.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Closes #2095
Description
Add a description of the changes made.
Testing
Describe the tests that were used to verify your changes.
get_spectrum
to True and adding log statementsAcceptance Criteria
How should the reviewer test your changes?
get_spectrum
normalise
param to "True" applies ShutterCount correctionDocumentation
How have you changed the documentation to reflect your changes? All changes should be noted in the appropriate file in docs/release_notes
docs/release_notes/next/feature-2095-apply_shuttercounts_normalisation