-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specview export tof wavelength #2218
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
49d9eaf
to
fe00cd2
Compare
7b2c2cf
to
1c42a4e
Compare
samtygier-stfc
requested changes
Jun 5, 2024
ef67ddf
to
5bb4e6d
Compare
samtygier-stfc
requested changes
Jun 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small changes
5bb4e6d
to
fa39ff4
Compare
samtygier-stfc
approved these changes
Jun 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now. I've tested making some CSV files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Closes #2216
Description
Testing
CSV output format with the following files loaded: sample, open
![image](https://private-user-images.githubusercontent.com/32413847/336772687-17ad7b73-9fb5-49ab-b79a-a17cb9a44d84.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTkzNjE5OTcsIm5iZiI6MTcxOTM2MTY5NywicGF0aCI6Ii8zMjQxMzg0Ny8zMzY3NzI2ODctMTdhZDdiNzMtOWZiNS00OWFiLWI3OWEtYTE3Y2I5YTQ0ZDg0LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MjYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjI2VDAwMjgxN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWNhOTA4NDhiMTUyYzc4ODdiMmYyMDU0YWQ2ZmQ1NGNkMGU5ZjI1OWMwMzlhMGQ5YTc3NmIyYzhjNDg1ZGE2ODImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.1vkzh3oTPTtnn_u7p4r7bRrlDJciksB7wy8kovxzyzA)
CSV output format with the following files loaded: sample, open, spectra log
![image](https://private-user-images.githubusercontent.com/32413847/336774526-ef8ff761-e9b6-4300-a8b1-99095cca31c7.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTkzNjE5OTcsIm5iZiI6MTcxOTM2MTY5NywicGF0aCI6Ii8zMjQxMzg0Ny8zMzY3NzQ1MjYtZWY4ZmY3NjEtZTliNi00MzAwLWE4YjEtOTkwOTVjY2EzMWM3LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MjYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjI2VDAwMjgxN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTJjZWNmYTBjZWIzMTFjYjVmN2FjMjk5ZWYxMjE2M2M0OTNiNTJjZGQ0YjA3NmYwYTBkZDdiYjI3NDllMTc3NDgmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.DtfBKhbAUCX3FIMY7cOzAH37OtcLjvi_l15FoVzwckQ)
Acceptance Criteria
Documentation
How have you changed the documentation to reflect your changes? All changes should be noted in the appropriate file in docs/release_notes
Updated Release Notes:
docs/release_notes/next/feature-2216-export_tof_wavelength_and_energy_to_csv