Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specview export tof wavelength #2218

Merged
merged 4 commits into from
Jun 10, 2024
Merged

Conversation

JackEAllen
Copy link
Collaborator

@JackEAllen JackEAllen commented Jun 5, 2024

Issue

Closes #2216

Description

  • Add columns to the CSV file exported by the spectrum viewer to include the unit conversions: ToF, Wavelength and Energy
  • Add row below header to specify units
  • Update tests to reflect changes made as part of this issue to spectrum viewer CSV export format

Testing

  • Manually tested and compared old output to new output (see screenshots)
  • Checked unit tests pass

CSV output format with the following files loaded: sample, open
image

CSV output format with the following files loaded: sample, open, spectra log
image

Acceptance Criteria

  • Spectrum Viewer CSV export without spectrum loaded exports in the same format as previously (no ToF, Wavelength or Energy)
  • Spectrum viewer CSV export with spectrum file loaded includes ToF, Wavelength and Energy Units including recon row denoting unit of measurement
  • Tests Pass

Documentation

How have you changed the documentation to reflect your changes? All changes should be noted in the appropriate file in docs/release_notes

Updated Release Notes: docs/release_notes/next/feature-2216-export_tof_wavelength_and_energy_to_csv

@JackEAllen JackEAllen force-pushed the specview_export_tof_wavelength branch from 49d9eaf to fe00cd2 Compare June 5, 2024 07:47
@coveralls
Copy link

Coverage Status

coverage: 72.774% (+0.04%) from 72.735%
when pulling fe00cd2 on specview_export_tof_wavelength
into 4d2ef3e on main.

@JackEAllen JackEAllen force-pushed the specview_export_tof_wavelength branch 2 times, most recently from 7b2c2cf to 1c42a4e Compare June 5, 2024 08:26
@coveralls
Copy link

Coverage Status

coverage: 72.761% (+0.03%) from 72.735%
when pulling 1c42a4e on specview_export_tof_wavelength
into 4d2ef3e on main.

@JackEAllen JackEAllen marked this pull request as ready for review June 5, 2024 08:55
@JackEAllen JackEAllen self-assigned this Jun 5, 2024
@JackEAllen JackEAllen force-pushed the specview_export_tof_wavelength branch 9 times, most recently from ef67ddf to 5bb4e6d Compare June 6, 2024 08:56
@coveralls
Copy link

Coverage Status

coverage: 72.731% (+0.02%) from 72.713%
when pulling ef67ddf on specview_export_tof_wavelength
into 937bb36 on main.

@coveralls
Copy link

Coverage Status

coverage: 72.726% (+0.01%) from 72.713%
when pulling 5bb4e6d on specview_export_tof_wavelength
into 937bb36 on main.

Copy link
Collaborator

@samtygier-stfc samtygier-stfc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small changes

mantidimaging/core/io/csv_output.py Outdated Show resolved Hide resolved
mantidimaging/gui/windows/spectrum_viewer/model.py Outdated Show resolved Hide resolved
@JackEAllen JackEAllen force-pushed the specview_export_tof_wavelength branch from 5bb4e6d to fa39ff4 Compare June 10, 2024 08:29
@coveralls
Copy link

Coverage Status

coverage: 72.771% (+0.02%) from 72.75%
when pulling fa39ff4 on specview_export_tof_wavelength
into f0def70 on main.

Copy link
Collaborator

@samtygier-stfc samtygier-stfc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now. I've tested making some CSV files.

@samtygier-stfc samtygier-stfc added this pull request to the merge queue Jun 10, 2024
Merged via the queue into main with commit fb03173 Jun 10, 2024
8 checks passed
@samtygier-stfc samtygier-stfc deleted the specview_export_tof_wavelength branch June 10, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spectrum Viewer: Export column for ToF, Wavelength and Energy
3 participants