Stack change units tests added to Spectrum Viewer #2235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeSullivan7
added
Quality: Testing
Release 🚀
|
Note: I have said that it progresses the issues in case we want to add some more tests to the PR :) |
JackEAllen
added
Release essential
| self.assertEqual(self.presenter.model.tof_mode, expected_tof_mode) | ||
|
|
||
| @parameterized.expand([ | ||
| (None, "Image Index", ToFUnitMode.IMAGE_NUMBER, np.arange(1, 10), [mock.call(False), |
There was a problem hiding this comment.
A small tweak that reduces the wrapping. If you change [mock.call(False), mock.call(True)], to [False, True], then you can turn the into calls in the method
expected_calls = [mock.call(b) for b in expected_calls]
samtygier-stfc
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Progresses #2213 and #2032
Description
Added unit tests to check the tof mode is changed correctly when:
ToFUnitMode.WAVELENGTH,ToFUnitMode.ENERGY,ToFUnitMode.TOF_US)These tests check that the tof mode is changed as expected but also if the right click units menu has the correct behaviour (i.e. disabling when there is no spectra file and enabling when there is a spectrum file).
A test has also been added to check that when there is no stack available in the spectrum viewer (i.e. it has been deleted in the Main Window), then the tof mode and right click menu behaves appropriately.
Acceptance Criteria
Test that all tests pass with
make checkDocumentation
Release note