Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds source file path to IMATLogFile, shows it in metadata #733

Merged
merged 8 commits into from
Dec 2, 2020
Merged

Adds source file path to IMATLogFile, shows it in metadata #733

merged 8 commits into from
Dec 2, 2020

Conversation

dtasev
Copy link
Contributor

@dtasev dtasev commented Nov 30, 2020 •
edited
Loading

Adds source file path to IMATLogFile, shows the file path in the metadata.

Also:

  • Adds separators in StackVisualiser context menu (main window and select ROI)
  • Re-orders the main StackVisualiser context menu

Fixes #702

Pasarus
Pasarus suggested changes Nov 30, 2020
View reviewed changes
Copy link
Contributor

@Pasarus Pasarus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I attempt to load a log, that has a different number of projections in it to the images loaded, it adds a log_file section to the history/metadata window, but the log is not used. Fix that and this should be ready to go!

Refactor add_log_to_sample, now checks if logs are suitable before se…
dd46fc6 
…tting

Also small refactor in add_180_deg to handle the case where a stack with the name is not found
@dtasev dtasev requested a review from Pasarus December 1, 2020 13:30
@dtasev
Copy link
Contributor Author

dtasev commented Dec 1, 2020

Latest changes should fix that

@dtasev
Copy link
Contributor Author

dtasev commented Dec 1, 2020

Coverage should be fine now 👍 Added tests for the new branches I introduced in dd46fc6

@Pasarus Pasarus merged commit 73ec280 into master Dec 2, 2020
@samtygier-stfc samtygier-stfc deleted the 702_see_if_logs_loaded branch April 22, 2021 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pasarus Pasarus Pasarus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ability to see if log is loaded somewhere in the GUI
2 participants
@dtasev @Pasarus