Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds projection angles load option #737

Merged
merged 7 commits into from
Dec 3, 2020
Merged

Adds projection angles load option #737

merged 7 commits into from
Dec 3, 2020

Conversation

dtasev
Copy link
Contributor

@dtasev dtasev commented Dec 1, 2020

Adds the option to load a projection angles file from the main window.

Also:

  • Adds projection angles handling in images. Projection angles from logs are still top priority.
  • Adds a simple parser for 2 formats of projection angles

The supported formats are comma separated or new-line separated:

0,0.1,0.2,0.3...

and

0
0.1
0.2
...

To test:

  • Load a preview stack (only 11 images)
  • To test either of the two formats copy and paste this into some file that you can select as a projection angle from File > Load proj angles
    • Test with/without a new line at the end.
0,0.1,0.2,0.3,0.4,0.5,0.6,0.7,0.8,0.9,1.0

and

0
0.1
0.2
0.3
0.4
0.5
0.6
0.7
0.8
0.9
1.0
  • Try adding/removing angles. It should show an error with the number of each (angles provided and images available)

Fixes #674

@dtasev dtasev requested a review from Pasarus December 1, 2020 18:22
Copy link
Contributor

@Pasarus Pasarus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments, functionally it works great and is almost ready to be merged!

@Pasarus Pasarus self-assigned this Dec 2, 2020
@dtasev dtasev requested a review from Pasarus December 2, 2020 16:43
@Pasarus Pasarus merged commit b00b650 into master Dec 3, 2020
@samtygier-stfc samtygier-stfc deleted the 674_projection_angles branch April 22, 2021 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide a manual way to input a file that contains projection angles
2 participants