Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate context menu in the a new main window menu #744

Merged
merged 7 commits into from
Dec 3, 2020
Merged

Duplicate context menu in the a new main window menu #744

merged 7 commits into from
Dec 3, 2020

Conversation

Pasarus
Copy link
Contributor

@Pasarus Pasarus commented Dec 3, 2020

Fixes #676

2 Things have happened in this PR:

  • I have disabled most main window options until a stack is loaded, if no stacks are present they should be disabled, and re-enabled later on.
  • The context menu for a loaded stack, should also be available in a menu called Image at the top of the Main window

To Test:

  • Open imaging, ensure that Image, Workflow, File->Save, File->LoadSampleLog, File->Load180DegreeProjection are disabled.
  • Load a stack
  • Ensure that all of the disabled items are now enabled.
  • Check that the Image menu only applies operations/actions to the currently viewed stack.

@dtasev dtasev self-requested a review December 3, 2020 14:04
@dtasev dtasev self-assigned this Dec 3, 2020
dtasev
dtasev suggested changes Dec 3, 2020
View reviewed changes
Copy link
Contributor

@dtasev dtasev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a comment on changing the actionLoadLog name

mantidimaging/gui/windows/main/view.py Show resolved Hide resolved
mantidimaging/gui/windows/stack_visualiser/view.py Show resolved Hide resolved
dtasev
dtasev suggested changes Dec 3, 2020
View reviewed changes
Copy link
Contributor

@dtasev dtasev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small type hint addition

mantidimaging/gui/utility/qt_helpers.py Outdated Show resolved Hide resolved
mantidimaging/gui/utility/qt_helpers.py Outdated Show resolved Hide resolved
@Pasarus
Apply suggestions from code review
f291b75 
Co-authored-by: Dimitar Tasev <dimitar.tasev@stfc.ac.uk>
@dtasev dtasev self-requested a review December 3, 2020 17:04
@dtasev dtasev merged commit 3428a6e into master Dec 3, 2020
@dtasev dtasev deleted the 676_duplicate_context_menu branch December 3, 2020 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtasev dtasev Awaiting requested review from dtasev

Assignees

@dtasev dtasev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move right click context menu to a window menu?
2 participants
@Pasarus @dtasev