Welcome screen implementation #753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think |
|
This now does everything the old dialog did, plus the new features. New links can be added to the list in mantidimaging/gui/windows/welcome_screen/presenter.py New issue checks (e.g. missing conda, insufficient free memory) could be added to check_issues() |
dtasev
suggested changes
Dec 8, 2020
dtasev
suggested changes
Dec 8, 2020
dtasev
force-pushed
the
671_welcome_screen
branch
from
b90e47e
to
98baea5
Compare
samtygier-stfc
force-pushed
the
671_welcome_screen
branch
from
98baea5
to
b90e47e
Compare
Shows at startup or from Help->About Checkbox to disable show are start Patched out in tests of MainWindowView to avoid displaying during tests
Add background Add OK button Add issue box, hidden until issues added Move old version error to welcome screen
Collection free functions in a class. Store values from calls to conda, so that they only get called once even if accessed from multiple places. from mantidimaging.core.utility.version_check import versions gives a global istance of the CheckVersion class, to prevent mutilple calls to conda.
samtygier-stfc
force-pushed
the
671_welcome_screen
branch
from
b90e47e
to
a1f5f0f
Compare
dtasev
approved these changes
Dec 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #671