Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added None as a line option #989

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Added None as a line option #989

merged 1 commit into from
Jun 17, 2024

Conversation

SilkeSchomann
Copy link
Collaborator

Description of work:

Added a new line style, "None". Here, only the error bars are plotted and not the line.

To test:

  1. Load a workspace into MSlice
  2. Do a cut
  3. Click on the settings icon and change the line style to 'None'
  4. Observe that the cut only shows error bars and no line
  5. Change the line style to any of the other options
  6. Check that the line on the plot is shown with the corresponding line style

Fixes #981

Copy link

@adriazalvarez adriazalvarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following test instructions, now there's the option to plot None and then it only plots the scatter plot and error bars.
I'm happy to approve.

Additionally, maybe I have missed the option, but it seemed you have to change line options individually for each line represented in the plot. It would be nice future feature to have the choice to change all the line styles at once.

@SilkeSchomann
Copy link
Collaborator Author

Following test instructions, now there's the option to plot None and then it only plots the scatter plot and error bars. I'm happy to approve.

Additionally, maybe I have missed the option, but it seemed you have to change line options individually for each line represented in the plot. It would be nice future feature to have the choice to change all the line styles at once.

@adriazalvarez This is an excellent suggestion. I will raise an issue for this.

@SilkeSchomann SilkeSchomann merged commit 4209816 into main Jun 17, 2024
2 checks passed
@SilkeSchomann SilkeSchomann deleted the 981_add_line_style_none branch June 17, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Add "none" option to line style
2 participants