[@mantine/core] NumberInput: Fix startValue nor working if min is…

… set (#5308)
mantinedev · Dec 4, 2023 · 0fd6499 · 0fd6499
1 parent 1ab6aab
commit 0fd6499
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/packages/@mantine/core/src/components/NumberInput/NumberInput.story.tsx b/packages/@mantine/core/src/components/NumberInput/NumberInput.story.tsx
@@ -24,6 +24,14 @@ export function Usage() {
   );
 }
 
+export function MinWithStartValue() {
+  return (
+    <div style={{ padding: 40 }}>
+      <NumberInput label="with min" min={-1000} startValue={20} />
+    </div>
+  );
+}
+
 export function OnChangeValue() {
   const [value, setValue] = useState<number | string>(345);
   return (

diff --git a/packages/@mantine/core/src/components/NumberInput/NumberInput.tsx b/packages/@mantine/core/src/components/NumberInput/NumberInput.tsx
@@ -239,7 +239,7 @@ export const NumberInput = factory<NumberInputFactory>((_props, ref) => {
 
   const increment = () => {
     if (typeof _value !== 'number' || Number.isNaN(_value)) {
-      setValue(min ?? clamp(startValue!, min, max));
+      setValue(clamp(startValue!, min, max));
     } else if (max !== undefined) {
       setValue(_value + step! <= max ? _value + step! : max);
     } else {
@@ -249,7 +249,7 @@ export const NumberInput = factory<NumberInputFactory>((_props, ref) => {
 
   const decrement = () => {
     if (typeof _value !== 'number' || Number.isNaN(_value)) {
-      setValue(max ?? clamp(startValue!, min, max));
+      setValue(clamp(startValue!, min, max));
     } else {
       setValue(getDecrementedValue({ value: _value, min, step, allowNegative }));
     }