[@mantine/core] AppShell: Fix header height 0 not working (#5514)

mantinedev · Jan 5, 2024 · 32f3c7a · 32f3c7a
1 parent e691391
commit 32f3c7a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/packages/@mantine/core/src/components/AppShell/AppShell.story.tsx b/packages/@mantine/core/src/components/AppShell/AppShell.story.tsx
@@ -28,7 +28,7 @@ export function Usage() {
         collapsed: { desktop: !asideOpened, mobile: !asideMobileOpened },
       }}
       header={{
-        height: 50,
+        height: 0,
         collapsed: !headerOpened,
       }}
       footer={{

diff --git a/packages/@mantine/core/src/core/utils/units-converters/rem.ts b/packages/@mantine/core/src/core/utils/units-converters/rem.ts
@@ -5,7 +5,7 @@ function scaleRem(remValue: string) {
 function createConverter(units: string, { shouldScale = false } = {}) {
   function converter(value: unknown): string {
     if (value === 0 || value === '0') {
-      return '0';
+      return '0rem';
     }
 
     if (typeof value === 'number') {