[@mantine/core] Notification: Make onClose handler optional

mantinedev · Mar 24, 2022 · a49cf93 · a49cf93
1 parent 2dbc1a6
commit a49cf93
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/src/mantine-core/src/components/Notification/Notification.test.tsx b/src/mantine-core/src/components/Notification/Notification.test.tsx
@@ -6,7 +6,6 @@ import { Notification, NotificationProps } from './Notification';
 const defaultProps: NotificationProps = {
   icon: 'test-icon',
   title: 'test-notification',
-  onClose: () => {},
   closeButtonProps: { title: 'test-close' },
 };
 

diff --git a/src/mantine-core/src/components/Notification/Notification.tsx b/src/mantine-core/src/components/Notification/Notification.tsx
@@ -18,7 +18,7 @@ export interface NotificationProps
   extends DefaultProps<NotificationStylesNames>,
     Omit<React.ComponentPropsWithoutRef<'div'>, 'title'> {
   /** Called when close button is clicked */
-  onClose(): void;
+  onClose?(): void;
 
   /** Notification line or icon color */
   color?: MantineColor;