Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

showNotification color is not the same depending on title presence #1627

Closed
mlarcher opened this issue Jun 13, 2022 · 1 comment
Closed

showNotification color is not the same depending on title presence #1627

mlarcher opened this issue Jun 13, 2022 · 1 comment
Labels
Fixed patch Completed issues that will be published with next patch (1.0.X)

Comments

@mlarcher
Copy link

mlarcher commented Jun 13, 2022

What package has an issue

@mantine/notifications

Describe the bug

When calling showNotifications with a title and a JSX markup, we end up with black text, but omitting the title we end up with gray text instead.

The syntax used is the one in the documentation (except for the message content), i.e.:

showNotification({
            title: 'Default notification',
            message: <div>some text some text</div>,
            styles: (theme) => ({
              root: {
                backgroundColor: theme.colors.blue[6],
                borderColor: theme.colors.blue[6],

                '&::before': { backgroundColor: theme.white },
              },

              title: { color: theme.white },
              description: { color: theme.white },
              closeButton: {
                color: theme.white,
                '&:hover': { backgroundColor: theme.colors.blue[7] },
              },
            }),
          })

In which browser did the problem occur

chrome

If possible, please include a link to a codesandbox with the reproduced problem

No response

Do you know how to fix the issue

No response

Are you willing to participate in fixing this issue and create a pull request with the fix

No response

Possible fix

No response

@mlarcher mlarcher added the bug label Jun 13, 2022
@rtivital rtivital added Fixed patch Completed issues that will be published with next patch (1.0.X) and removed bug labels Aug 11, 2022
rtivital added a commit that referenced this issue Aug 12, 2022
…ificity to allow color overriding with Styles API (#1627)
@rtivital
Copy link
Member

Fixed in 5.1.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed patch Completed issues that will be published with next patch (1.0.X)
Projects
None yet
Development

No branches or pull requests

2 participants