Invlaid types for Custom Component (MyComponentStylesNames)

[maazakn]

Link to the page where something nasty is located

https://mantine.dev/guides/custom-components/

Exact quote of what is wrong

MyComponent.styles.ts

import { createStyles, MantineNumberSize } from '@mantine/core';

// Styles params are optional
export interface MyComponentStylesParams {
  radius: MantineNumberSize;
}

MyComponent.tsx

interface MyComponentProps extends DefaultProps<MyComponentStylesNames, MyComponentStylesParams> {
  radius?: MantineNumberSize;
}

There is a type mismatch in the radius type ( syles.ts file) where it is marked as required while in MyComponent.tsx it is Optional

Are you willing to create pull request with the fix?

Yes

[rtivital]

You are welcome to create a PR with a fix

[maazakn]

Hey Mantinedev/Mantine, Is there any special instructions or process for raising PR?

…

On Wed, Jan 4, 2023, 11:11 PM Vitaly Rtishchev ***@***.***> wrote: You are welcome to create a PR with a fix — Reply to this email directly, view it on GitHub <#3281 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AMLV5DDTBJIXQWCYLEVQK3DWQW4MPANCNFSM6AAAAAATRAZPII> . You are receiving this because you authored the thread.Message ID: ***@***.***>