Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal's CloseButtonProps does not accept size prop #4793

Closed
ronny-lark opened this issue Sep 19, 2023 · 1 comment
Closed

Modal's CloseButtonProps does not accept size prop #4793

ronny-lark opened this issue Sep 19, 2023 · 1 comment
Labels
Fixed patch Completed issues that will be published with next patch (1.0.X)

Comments

@ronny-lark
Copy link

ronny-lark commented Sep 19, 2023

What package has an issue

@mantine/modals

Describe the bug

In Mantine 7, attempting

modals.openConfirmModal({
  closeButtonProps: { size: 'xl' }
})

Throws a TS error claiming that the prop doesn't exist.

The prop exists on CloseButton, which in the docs says it's used in modals.
If adding @ts-ignore I can see that the prop does in fact have an affect:
image
image

What version of @mantine/* page do you have in package.json? (Note that all @mantine/* packages must have the same version in order to work correctly)

7.0.0

If possible, please include a link to a codesandbox with the reproduced problem

No response

Do you know how to fix the issue

No

Are you willing to participate in fixing this issue and create a pull request with the fix

None

Possible fix

No response

@rtivital rtivital added the Fixed patch Completed issues that will be published with next patch (1.0.X) label Sep 21, 2023
@rtivital
Copy link
Member

The issue is resolved in 7.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed patch Completed issues that will be published with next patch (1.0.X)
Projects
None yet
Development

No branches or pull requests

2 participants