Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combobox height differs from TextInput height with same size #4925

Closed
lgaspari opened this issue Sep 29, 2023 · 2 comments
Closed

Combobox height differs from TextInput height with same size #4925

lgaspari opened this issue Sep 29, 2023 · 2 comments
Labels
Fixed patch Completed issues that will be published with next patch (1.0.X)

Comments

@lgaspari
Copy link
Contributor

What package has an issue

@mantine/core

Describe the bug

Previously in v6, the MultiSelect with size="xs" had a height of 30px, which is the exact same height as the TextInput using the same size prop. However, in v7 we can see that the MultiSelect height changed from 30px to 31.2px, making it look slightly off. The same applies for all size values, except for "xl" that matches 60px.

See comparison: v6 vs. v7

What version of @mantine/* packages do you have in package.json? (Note that all @mantine/* packages must have the same version in order to work correctly)

7.1.0

If possible, please include a link to a codesandbox with the reproduced problem

https://codesandbox.io/s/focused-flower-vlhtg6?file=/src/App.tsx

Do you know how to fix the issue

No

Are you willing to participate in fixing this issue and create a pull request with the fix

Yes

Possible fix

Might be related to --input-padding-y-{size} value

@rtivital rtivital added the Fixed patch Completed issues that will be published with next patch (1.0.X) label Oct 1, 2023
@rtivital
Copy link
Member

rtivital commented Oct 2, 2023

Fixed in 7.1.1

@rtivital rtivital closed this as completed Oct 2, 2023
@lgaspari
Copy link
Contributor Author

lgaspari commented Oct 2, 2023

Hey @rtivital, could it be possible that the MultiSelect's input height when size="xs" is 30.19px instead of 30px? You can use the same v7 codesandbox to reproduce.

(I know it's a slight difference of 0.19px, but still wanted to call that out!)

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed patch Completed issues that will be published with next patch (1.0.X)
Projects
None yet
Development

No branches or pull requests

2 participants