Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropzone dnd is buggy #4934

Closed
D3kion opened this issue Oct 1, 2023 · 10 comments
Closed

Dropzone dnd is buggy #4934

D3kion opened this issue Oct 1, 2023 · 10 comments
Labels
Needs reproduction Issues without reproduction, closed within a week if the reproduction is not provided

Comments

@D3kion
Copy link

D3kion commented Oct 1, 2023

What package has an issue

@mantine/dropzone

Describe the bug

When dragging file onto dropzone it works correct only on outter paddings

What version of @mantine/* packages do you have in package.json? (Note that all @mantine/* packages must have the same version in order to work correctly)

7.0 but tested in 7.1 too

If possible, please include a link to a codesandbox with the reproduced problem

No response

Do you know how to fix the issue

Yes

Are you willing to participate in fixing this issue and create a pull request with the fix

No

Possible fix

Locally fixed version from Mantine-ui with .mantine-Dropzone-inner { pointer-events: none }, but i think that's not specific to component from Mantine-ui

@rtivital
Copy link
Member

rtivital commented Oct 1, 2023

Please provide a reproduction (video) or sandbox with steps to reproduce. It is not clear what the issue is based on the issue description.

@rtivital rtivital added the Needs reproduction Issues without reproduction, closed within a week if the reproduction is not provided label Oct 1, 2023
@D3kion
Copy link
Author

D3kion commented Oct 1, 2023

Sry but i'm lazy:D
Try to move file to dropzone
However that's just visual bug, but disappointing

image
image

@D3kion
Copy link
Author

D3kion commented Oct 1, 2023

Tested only on latest versions of Chrome btw

@D3kion
Copy link
Author

D3kion commented Oct 2, 2023

Yo, seems like dropzone now is completly broken
Haven't tested locally, but in docs dnd isn't working at all, and any upload results error in console

@DenisBessa
Copy link
Contributor

Yo, seems like dropzone now is completly broken Haven't tested locally, but in docs dnd isn't working at all, and any upload results error in console

Yeah, same here.

@joao-vasconcelos
Copy link

joao-vasconcelos commented Oct 2, 2023

Hey! I'm getting this error when following the docs, and only on dropping/choosing a file:

TypeError: attr_accept__WEBPACK_IMPORTED_MODULE_0__ is not a function
    at A (webpack-internal:///(app-pages-browser)/./node_modules/react-dropzone-esm/dist/esm/utils.mjs:29:959)
    at eval (webpack-internal:///(app-pages-browser)/./node_modules/react-dropzone-esm/dist/esm/index.mjs:12:6515)
    at Array.forEach (<anonymous>)
    at eval (webpack-internal:///(app-pages-browser)/./node_modules/react-dropzone-esm/dist/esm/index.mjs:12:6436)
    at eval (webpack-internal:///(app-pages-browser)/./node_modules/react-dropzone-esm/dist/esm/index.mjs:12:7515)

Reverting to 7.1.0 fixes the issue.

@rtivital
Copy link
Member

rtivital commented Oct 2, 2023

Both issues are resolved in 7.1.2

@rtivital rtivital closed this as completed Oct 2, 2023
@D3kion
Copy link
Author

D3kion commented Oct 2, 2023

Thanks a lot!

@joao-vasconcelos
Copy link

Thank you!

@alesh-kajzar
Copy link

alesh-kajzar commented Oct 21, 2023

Looks like this is still an issue in 7.1.5. When a file is dragged above inner element (e.g.Text), dropzone looks like in Idle state. It is only visual bug, the dropzone still accepts the file. @D3kion image shows it perfectly:

271826021-134ffa97-fccf-4c8d-bb81-8d31ba1736cd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs reproduction Issues without reproduction, closed within a week if the reproduction is not provided
Projects
None yet
Development

No branches or pull requests

5 participants