Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V7] Bug: portalProps doesn't accept className without breaking whole app #4935

Closed
7iomka opened this issue Oct 1, 2023 · 1 comment
Closed
Labels
Fixed patch Completed issues that will be published with next patch (1.0.X)

Comments

@7iomka
Copy link
Contributor

7iomka commented Oct 1, 2023

What package has an issue

@mantine/core

Describe the bug

image

When I added className in portalProps in Menu component (at least), I have clientside error:
InvalidCharacterError: Failed to execute 'add' on 'DOMTokenList': The token provided ('hidden xl:block') contains HTML space characters, which are not valid in tokens.

image

When className is not passed to portalProps, or it doesn't consist any space, error is gone.

This is critical bug or I'm missing something?

What version of @mantine/* packages do you have in package.json? (Note that all @mantine/* packages must have the same version in order to work correctly)

latest

If possible, please include a link to a codesandbox with the reproduced problem

No response

Do you know how to fix the issue

None

Are you willing to participate in fixing this issue and create a pull request with the fix

None

Possible fix

No response

@7iomka 7iomka changed the title [V7] portalProps doesn't accept className without breaking whole app [V7] Bug: portalProps doesn't accept className without breaking whole app Oct 1, 2023
rtivital added a commit that referenced this issue Oct 1, 2023
@rtivital rtivital added the Fixed patch Completed issues that will be published with next patch (1.0.X) label Oct 1, 2023
@rtivital
Copy link
Member

rtivital commented Oct 2, 2023

Fixed in 7.1.1

@rtivital rtivital closed this as completed Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed patch Completed issues that will be published with next patch (1.0.X)
Projects
None yet
Development

No branches or pull requests

2 participants