Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DatePicker] hideOutsideDates is only respected when importing Mantine styles #5003

Closed
filiptammergard opened this issue Oct 9, 2023 · 1 comment
Labels
Fixed patch Completed issues that will be published with next patch (1.0.X)

Comments

@filiptammergard
Copy link
Contributor

What package has an issue

@mantine/dates

Describe the bug

hideOutsideDates is not respected without importing Mantine's CSS.

The description of hideOutsideDates is "Determines whether outside dates should be hidden, defaults to false". I'd argue that the dates should disappear even without importing Mantine's CSS. It's not a styling opinion, it's a matter of whether the prop works or not.

What version of @mantine/* packages do you have in package.json? (Note that all @mantine/* packages must have the same version in order to work correctly)

7.1.2

If possible, please include a link to a codesandbox with the reproduced problem

https://codesandbox.io/s/black-field-kyjyt4?file=/src/App.tsx

Do you know how to fix the issue

Yes

Are you willing to participate in fixing this issue and create a pull request with the fix

Yes

Possible fix

Do not render the Day buttons that's outside when hideOutsideDates is true.

rtivital added a commit that referenced this issue Dec 4, 2023
@rtivital rtivital added the Fixed patch Completed issues that will be published with next patch (1.0.X) label Dec 4, 2023
@rtivital
Copy link
Member

rtivital commented Dec 7, 2023

Fixed in 7.3.1

@rtivital rtivital closed this as completed Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed patch Completed issues that will be published with next patch (1.0.X)
Projects
None yet
Development

No branches or pull requests

2 participants