Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification transition problem (@mantine/notifications) #5007

Closed
Wiwida opened this issue Oct 10, 2023 · 5 comments
Closed

Notification transition problem (@mantine/notifications) #5007

Wiwida opened this issue Oct 10, 2023 · 5 comments
Labels
Fixed patch Completed issues that will be published with next patch (1.0.X)

Comments

@Wiwida
Copy link

Wiwida commented Oct 10, 2023

What package has an issue

@mantine/notifications

Describe the bug

Since V7 I've had a transition problem when the notification appears and disappears.
I did some digging and found the problem, which is due to the "style" property of the show method.
Without the "style" property, the transition occurs, but if I add it (ex : style: {"backgroundColor": "red"}), the transition at the notification's appearance and disappearance is suppressed.
Everything works fine in V6.
What's more, the documentation tells me that this shouldn't be a problem.
Is this intentional or is it a mistake on my part ?

What version of @mantine/* packages do you have in package.json? (Note that all @mantine/* packages must have the same version in order to work correctly)

7.1.2

If possible, please include a link to a codesandbox with the reproduced problem

No response

Do you know how to fix the issue

No

Are you willing to participate in fixing this issue and create a pull request with the fix

No

Possible fix

No response

@rtivital
Copy link
Member

How do you set style property?

@rommni
Copy link

rommni commented Oct 10, 2023

Can reproduce with this code sample :
https://codesandbox.io/s/nostalgic-dream-n6qdj8?file=/src/App.tsx

@rtivital
Copy link
Member

Thanks, the issue will be resolved in one of the next patches

@rtivital rtivital added the TBD It is clear how to fix the issue and the fix will be provided soon label Oct 10, 2023
@NinhUTCK61
Copy link

@rommni I have noticed that the attribute limit notification is not functioning properly

@rtivital rtivital added Fixed patch Completed issues that will be published with next patch (1.0.X) and removed TBD It is clear how to fix the issue and the fix will be provided soon labels Oct 12, 2023
@rtivital
Copy link
Member

The issue has been resolved in 7.1.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed patch Completed issues that will be published with next patch (1.0.X)
Projects
None yet
Development

No branches or pull requests

4 participants