Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RichTextEditor.Link missing key control in styles and classNames props although functionality works #5171

Closed
HariVP03 opened this issue Nov 2, 2023 · 1 comment
Labels
Fixed patch Completed issues that will be published with next patch (1.0.X)

Comments

@HariVP03
Copy link

HariVP03 commented Nov 2, 2023

What package has an issue

@mantine/tiptap

Describe the bug

The RichTextEditor.Link component accepts a key in the styles or classNames like other Rich Text Button if someone wants to override the default styles. However, the type does not have the control key and I had to @ts-ignore it.

What version of @mantine/* packages do you have in package.json? (Note that all @mantine/* packages must have the same version in order to work correctly)

7.1.7

If possible, please include a link to a codesandbox with the reproduced problem

No response

Do you know how to fix the issue

Yes

Are you willing to participate in fixing this issue and create a pull request with the fix

Yes

Possible fix

Add the control key in the type for RichTextEditor.Link for styles and classNames props

@HariVP03 HariVP03 changed the title RichTextEditor.Link missing prop control in styles and classNames although functionality works RichTextEditor.Link missing key control in styles and classNames props although functionality works Nov 2, 2023
rtivital added a commit that referenced this issue Dec 4, 2023
@rtivital rtivital added the Fixed patch Completed issues that will be published with next patch (1.0.X) label Dec 4, 2023
@rtivital
Copy link
Member

rtivital commented Dec 7, 2023

Fixed in 7.3.1

@rtivital rtivital closed this as completed Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed patch Completed issues that will be published with next patch (1.0.X)
Projects
None yet
Development

No branches or pull requests

2 participants