Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not specifying the language prop in CodeHighlightTabs causes a crash #5178

Closed
jesse-r2c opened this issue Nov 2, 2023 · 1 comment
Closed
Labels
Fixed patch Completed issues that will be published with next patch (1.0.X)

Comments

@jesse-r2c
Copy link

What package has an issue

@mantine/code-highlight

Describe the bug

The language prop in CodeHighlightTabs is defined as optional, but not setting that property causes a crash.

image

What version of @mantine/* packages do you have in package.json? (Note that all @mantine/* packages must have the same version in order to work correctly)

7.1.7

If possible, please include a link to a codesandbox with the reproduced problem

https://codesandbox.io/s/condescending-https-mzkldz?file=/src/App.tsx

Do you know how to fix the issue

Yes

Are you willing to participate in fixing this issue and create a pull request with the fix

None

Possible fix

  • Make language a required prop
  • Add a fallback to plaintext if language is undefined
rtivital added a commit that referenced this issue Nov 7, 2023
@rtivital rtivital added the Fixed patch Completed issues that will be published with next patch (1.0.X) label Nov 7, 2023
@rtivital
Copy link
Member

rtivital commented Nov 7, 2023

Fixed in 7.2.1.

@rtivital rtivital closed this as completed Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed patch Completed issues that will be published with next patch (1.0.X)
Projects
None yet
Development

No branches or pull requests

2 participants