Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Component Text - inline prop is not working #5190

Closed
gorkunov opened this issue Nov 4, 2023 · 1 comment · Fixed by #5194
Closed

Component Text - inline prop is not working #5190

gorkunov opened this issue Nov 4, 2023 · 1 comment · Fixed by #5194

Comments

@gorkunov
Copy link
Contributor

gorkunov commented Nov 4, 2023

It seems there is a typo in this line which is breaking configuration for line-height (1).

mantine/src/mantine-core/src/components/Text/Text.module.css

Line 49 in b10a096

--_text-line-height: 1;

@gorkunov
Copy link
Contributor Author

gorkunov commented Nov 4, 2023 •
edited

I don't clearly understand what --_ at the beginning means but seems the right version would be just line-height: 1

update: prepared patch to fix the issue.

gorkunov added a commit to gorkunov/mantine that referenced this issue Nov 5, 2023
@gorkunov
[@mantine/core]: Text: Fix inline prop in css (mantinedev#5190)
5931fc6
@gorkunov gorkunov mentioned this issue Nov 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[@mantine/core]: Text: Fix inline prop in css (mantinedev#5190) gorkunov/mantine
1 participant
@gorkunov