Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alert component without children #5196

Closed
mnakhli opened this issue Nov 6, 2023 · 1 comment
Closed

Alert component without children #5196

mnakhli opened this issue Nov 6, 2023 · 1 comment
Labels
Fixed patch Completed issues that will be published with next patch (1.0.X)

Comments

@mnakhli
Copy link

mnakhli commented Nov 6, 2023

What package has an issue

@mantine/core

Describe the bug

In Alert component, when we remove children, there is more distance from the bottom of the title to the frame border.
Screenshot 1402-08-15 at 10 32 59

What version of @mantine/* packages do you have in package.json? (Note that all @mantine/* packages must have the same version in order to work correctly)

latest

If possible, please include a link to a codesandbox with the reproduced problem

https://github.com/mantinedev/mantine/blob/master/src/mantine-core/src/components/Alert/Alert.tsx

Do you know how to fix the issue

Yes

Are you willing to participate in fixing this issue and create a pull request with the fix

No

Possible fix

You should give the children the margin-top instead of the title the margin-bottom.

rtivital added a commit that referenced this issue Nov 7, 2023
@rtivital rtivital added the Fixed patch Completed issues that will be published with next patch (1.0.X) label Nov 7, 2023
@rtivital
Copy link
Member

rtivital commented Nov 7, 2023

Fixed in 7.2.1.

@rtivital rtivital closed this as completed Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed patch Completed issues that will be published with next patch (1.0.X)
Projects
None yet
Development

No branches or pull requests

2 participants