Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTL issues #5250

Closed
CripyIce opened this issue Nov 14, 2023 · 7 comments
Closed

RTL issues #5250

CripyIce opened this issue Nov 14, 2023 · 7 comments
Labels
Fixed patch Completed issues that will be published with next patch (1.0.X)

Comments

@CripyIce
Copy link

What package has an issue?

@mantine/core

Describe the bug

What version of @mantine/* packages do you have in package.json? (Note that all @mantine/* packages must have the same version in order to work correctly)

7.2.2

If possible, please include a link to a codesandbox with a minimal reproduction

No response

Do you know how to fix the issue

None

Do you want to send a pull request with a fix?

None

Possible fix

No response

@abdullahahmeda
Copy link

Also for <NavLink />, label has text-align: left (But it should be text-align: right)

@aalirezamoradii
Copy link

Also for AppShellNavbar when app shell layout is alt

@abdullahahmeda
Copy link

abdullahahmeda commented Nov 21, 2023

Another issue with <Switch /> is that the direction of the circle inside the switch (it is called the "label" in docs) is not reversed for RTL. The circle should be besides the text if the Switch is active.
image
This is how it looks in English:
image

@mmounirf
Copy link
Contributor

mmounirf commented Nov 28, 2023

@CripyIce

  • For the segmented control component, react node as a label demo has ml={10} you can simply change it in your use case.
  • For Tabs with vertical placement, the padding comes from pl="sm", you can change the padding on Tabs.Panel component to your desired direction
  • For Modal/Drawer it's mentioned in the docs a fix for offset caused by third-party library react-remove-scroll-bar however I couldn't put that in use with RTL, but I was able to fix it by explicitly setting zero right for components' inner element. Here's a demo for Modal and Drawer

For other issues, I'm currently looking into them and hopefully contribute with a PR

@rtivital
Copy link
Member

rtivital commented Dec 4, 2023

  • SegmentedControl demo: Icons and text have no space between them
  • Autocomplete: No space between text and divider
  • Pill: Text is too close to the edge
  • NavLink: Text stays on the left (also in nested)
  • Tabs demo: No padding for the content
  • Drawer: Extra padding on the right – must be resolved on user side with react-remove-scroll
  • Indicator: Positions start/end are not truly working – works as intended
  • Kbd: Order is incorrect (should be command->shift->m rather then command->m->shift)
  • Spoiler: “Show more” stays in the left
  • Spotlight: Icons and text are too close

The fixes will be available with next patch.

@rtivital rtivital added the Fixed patch Completed issues that will be published with next patch (1.0.X) label Dec 4, 2023
@CripyIce
Copy link
Author

CripyIce commented Dec 5, 2023

@rtivital Thanks for fixing those issues!
But regarding Indicator, shouldn't start (for example) work as left in LTR and right in RTL, because right now start is left in both directions.

@rtivital
Copy link
Member

rtivital commented Dec 7, 2023

Fixed in 7.3.1

@rtivital rtivital closed this as completed Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed patch Completed issues that will be published with next patch (1.0.X)
Projects
None yet
Development

No branches or pull requests

5 participants