Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v7: Grid styles now include overflow: hidden by default #5276

Closed
itsravenous opened this issue Nov 17, 2023 · 1 comment
Closed

v7: Grid styles now include overflow: hidden by default #5276

itsravenous opened this issue Nov 17, 2023 · 1 comment

Comments

@itsravenous
Copy link

itsravenous commented Nov 17, 2023

What package has an issue?

@mantine/core

Describe the bug

The Grid component now sets overflow: hidden on its root element, which it did not in v6.

I can't see the reason for this, but could well be missing something.

I noticed this because we have some cards that sit in a Grid and on hover have an overlay that can expand beyond the bounds of the grid. After upgrading to v7, this was clipped because of the overflow rule. As can be seen in the linked codesandbox, drop shadows on children are clipped as well.

Overriding the style works, so it's not a huge problem, but if there's no reason for it to be there I'm happy to submit a PR to remove.

What version of @mantine/* packages do you have in package.json? (Note that all @mantine/* packages must have the same version in order to work correctly)

7.2.2

If possible, please include a link to a codesandbox with a minimal reproduction

https://codesandbox.io/s/sharp-sunset-83cdkc

Do you know how to fix the issue

Yes

Do you want to send a pull request with a fix?

Yes

Possible fix

Remove the overflow: hidden rule.

@rtivital
Copy link
Member

rtivital commented Dec 4, 2023

Starting from version 7.3.0 Grid component supports overflow prop – https://mantine.dev/core/grid/#overflow-hidden

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants