Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make @mantine/tiptap not dependent on tabler-icons #5279

Closed
bvkimball opened this issue Nov 17, 2023 · 4 comments
Closed

Make @mantine/tiptap not dependent on tabler-icons #5279

bvkimball opened this issue Nov 17, 2023 · 4 comments
Labels
Fixed patch Completed issues that will be published with next patch (1.0.X)

Comments

@bvkimball
Copy link

What package has an issue?

@mantine/tiptap

Describe the bug

I use lucide-react, tabler-icons are great just not what i use.
but now i have to bundle them as dependency.

Not sure how you make it optional.

What version of @mantine/* packages do you have in package.json? (Note that all @mantine/* packages must have the same version in order to work correctly)

7.2.2

If possible, please include a link to a codesandbox with a minimal reproduction

No response

Do you know how to fix the issue

No

Do you want to send a pull request with a fix?

No

Possible fix

No response

@rasyidf
Copy link

rasyidf commented Nov 23, 2023

I agree with this.
Building my project with mantine/tiptap and Vite significantly slows down, especially on my low-performance laptop. The delay is substantial, around 20 seconds on vercel and minutes on my less capable machine. The problem seems to be the transformation of 4000 icons, even though only 26 of them are utilized by tiptap.

The worst part is the transformation keep running even when I change every icon on the toolbar

@rasyidf
Copy link

rasyidf commented Dec 2, 2023

Adding context here, with only mantine/core, mantine/tiptap and react router dom in myapp, it needs to transform 7000 modules
image

@rtivital rtivital added the Fixed patch Completed issues that will be published with next patch (1.0.X) label Dec 4, 2023
@cayter
Copy link

cayter commented Dec 7, 2023

Just found out about this today. Possible to replace it with @iconify-react? We're currently using it and it downloads the icons on demand.

@rtivital
Copy link
Member

rtivital commented Dec 7, 2023

Fixed in 7.3.1

@rtivital rtivital closed this as completed Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed patch Completed issues that will be published with next patch (1.0.X)
Projects
None yet
Development

No branches or pull requests

4 participants