Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lineClamp not supported anymore on <Title />? #5321

Closed
atumas-bananamilk opened this issue Nov 24, 2023 · 4 comments
Closed

lineClamp not supported anymore on <Title />? #5321

atumas-bananamilk opened this issue Nov 24, 2023 · 4 comments
Labels
Fixed patch Completed issues that will be published with next patch (1.0.X)

Comments

@atumas-bananamilk
Copy link

What package has an issue?

@mantine/core

Describe the bug

v7 doesn't support lineClamp for <Title /> anymore?

Screenshot 2023-11-24 at 18 20 08

What version of @mantine/* packages do you have in package.json? (Note that all @mantine/* packages must have the same version in order to work correctly)

^7.2.2

If possible, please include a link to a codesandbox with a minimal reproduction

No response

Do you know how to fix the issue

None

Do you want to send a pull request with a fix?

None

Possible fix

No response

@jt561
Copy link

jt561 commented Nov 24, 2023

Yes. The docs states that it's been removed from title. I've had to result to just using Text

@atumas-bananamilk
Copy link
Author

I guess will have to completely migrate to <Text /> from now on.
Makes no sense but ok.

Migrations:

    <Title order={3} lineClamp={1}>Nice one</Title>
    <Text fz={22} fw={700} lineClamp={1}>Nice one</Text> // identical to Title order = 3

    <Title order={2} lineClamp={1}>Nice one</Title>
    <Text fz={26} fw={700} lineClamp={1}>Nice one</Text> // identical to Title order = 2

    <Title order={1} lineClamp={1}>Nice one</Title>
    <Text fz={34} fw={700} lineClamp={1}>Nice one</Text> // identical to Title order = 1

@jt561
Copy link

jt561 commented Nov 25, 2023

Yeah honestly it's a shame but there's nothing else we can do. I guess you can also add component="h1" too which should add the h1 tag.

@rtivital rtivital added the Fixed patch Completed issues that will be published with next patch (1.0.X) label Dec 4, 2023
@rtivital
Copy link
Member

rtivital commented Dec 7, 2023

Fixed in 7.3.1

@rtivital rtivital closed this as completed Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed patch Completed issues that will be published with next patch (1.0.X)
Projects
None yet
Development

No branches or pull requests

3 participants