Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

createPolymorphicComponent #5367

Closed
zeestack opened this issue Dec 4, 2023 · 1 comment
Closed

createPolymorphicComponent #5367

zeestack opened this issue Dec 4, 2023 · 1 comment
Labels
Fixed patch Completed issues that will be published with next patch (1.0.X)

Comments

@zeestack
Copy link

zeestack commented Dec 4, 2023

What package has an issue?

@mantine/core

Describe the bug

Can we please remove this "use client" directive from createPolymorphicComponent function. Its just a plane function and it should be callable from both the client and the server.

What version of @mantine/* packages do you have in package.json? (Note that all @mantine/* packages must have the same version in order to work correctly)

7.2.2

If possible, please include a link to a codesandbox with a minimal reproduction

No response

Do you know how to fix the issue

Yes

Do you want to send a pull request with a fix?

None

Possible fix

No response
rtivital added a commit that referenced this issue Dec 4, 2023
@rtivital
[@mantine/core] Remove use client from createPolymorphicComponent fac…
abe200e 
…tory (#5367)
@rtivital rtivital added the Fixed patch Completed issues that will be published with next patch (1.0.X) label Dec 4, 2023
@rtivital
Copy link
Member

rtivital commented Dec 7, 2023

Fixed in 7.3.1

@rtivital rtivital closed this as completed Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Fixed patch Completed issues that will be published with next patch (1.0.X)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rtivital @zeestack