Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Combobox.Search z-index #5368

Closed
dimbslmh opened this issue Dec 4, 2023 · 3 comments
Closed

Remove Combobox.Search z-index #5368

dimbslmh opened this issue Dec 4, 2023 · 3 comments
Labels
Fixed patch Completed issues that will be published with next patch (1.0.X)

Comments

@dimbslmh
Copy link

dimbslmh commented Dec 4, 2023

The z-index: 1000; is causing input sections to be hidden behind it.

Looks to me that Combobox.Search is always nested in the Combobox.Dropdown, so it doesn't look like it's required to have?

.section {
pointer-events: var(--_section-pointer-events);
position: absolute;
z-index: 1;

.search {
margin-left: calc(var(--_combobox-padding) * -1);
margin-right: calc(var(--_combobox-padding) * -1);
margin-top: calc(var(--_combobox-padding) * -1);
width: calc(100% + var(--_combobox-padding) * 2);
border-top-width: 0;
border-right-width: 0;
border-left-width: 0;
border-bottom-left-radius: 0;
border-bottom-right-radius: 0;
margin-bottom: var(--_combobox-padding);
background-color: var(--_search_background);
position: relative;
z-index: 1000;

@rtivital
Copy link
Member

rtivital commented Dec 5, 2023

Can you provide an example that causes the issue? Screenshot with explanation or video

@dimbslmh
Copy link
Author

dimbslmh commented Dec 5, 2023

Can you provide an example that causes the issue? Screenshot with explanation or video

Sure.

https://codesandbox.io/p/sandbox/friendly-snow-7flnpj?file=%2Fsrc%2FSelectDropdownSearch.tsx%3A42%2C33

Screen.Recording.2023-12-05.at.5.06.27.PM.mov

rtivital added a commit that referenced this issue Dec 7, 2023
@rtivital rtivital added the Fixed patch Completed issues that will be published with next patch (1.0.X) label Dec 7, 2023
@rtivital
Copy link
Member

Fixed in 7.3.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed patch Completed issues that will be published with next patch (1.0.X)
Projects
None yet
Development

No branches or pull requests

2 participants