-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Menu has incorrect ARIA roles #5372
Labels
Fixed patch
Completed issues that will be published with next patch (1.0.X)
Comments
Merged
2 tasks
Fixed in #5335 |
Hi, I'm still seeing the issue present in 7.3.1. I'm also not seeing anything in that pull request that would have addressed the |
rtivital
added
the
Fixed patch
Completed issues that will be published with next patch (1.0.X)
label
Dec 8, 2023
rtivital
added a commit
that referenced
this issue
Dec 8, 2023
Fixed in 7.3.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What package has an issue?
@mantine/core
Describe the bug
The Menu and MenuDropdown components fail a WCAG/508 accessibility scan with "Certain ARIA roles must contain particular children". There is an extra div wrapping the elements with
role=menuitem
causing them not to be direct descents of the element withrole=menu
as they should be.What version of @mantine/* packages do you have in package.json? (Note that all @mantine/* packages must have the same version in order to work correctly)
6.0.21
If possible, please include a link to a codesandbox with a minimal reproduction
No response
Do you know how to fix the issue
None
Do you want to send a pull request with a fix?
None
Possible fix
Remove extra div or add
role=group
to it, example: https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/group_role#examplesThe text was updated successfully, but these errors were encountered: