Combobox onClose does not work

[crabvk]

Dependencies check up

• I have verified that I use latest version of all @mantine/* packages

What version of @mantine/* packages do you have in package.json?

7.3.2

What package has an issue?

@mantine/core

What framework do you use?

Vite

In which browsers you can reproduce the issue?

Firefox

Describe the bug

I took the first code example from the Combobox examples page called "Basic select". Added onClose={() => alert('onClose')} to Combobox component. The event does not trigger when I close dropdown. onOpen works just fine though.

If possible, include a link to a codesandbox with a minimal reproduction

https://codesandbox.io/p/sandbox/infallible-leakey-5w99kk

Possible fix

No response

Self-service

• I would be willing to implement a fix for this issue

[kartikm02]

I would be willing to fix this issue

[ID-JA]

@rtivital
I've looked at the issue, and it seems like the onClose prop isn't being triggered even if we passed it as a prop for the Combobox component.

I've made a small adjustment to the Combobox.tsx file.

 <Popover
        opened={store.dropdownOpened}
        {...others}
-       onClose={store.closeDropdown}
+      onClose={onClose || store.closeDropdown}
        withRoles={false}
        unstyled={unstyled}
      >
        {children}
</Popover>

I've checked the Select component behaviour (it closed on clicking outside).

should I make a pull request?

[rtivital]

You are welcome to submit a PR with a fix