Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rating size type #5470

Closed
1 of 2 tasks
CripyIce opened this issue Dec 23, 2023 · 1 comment
Closed
1 of 2 tasks

Rating size type #5470

CripyIce opened this issue Dec 23, 2023 · 1 comment
Labels
Fixed patch Completed issues that will be published with next patch (1.0.X)

Comments

@CripyIce
Copy link

Dependencies check up

  • I have verified that I use latest version of all @mantine/* packages

What version of @mantine/* packages do you have in package.json?

7.3.2

What package has an issue?

@mantine/core

What framework do you use?

Remix

In which browsers you can reproduce the issue?

All

Describe the bug

Rating size type is MantineSize while entering a number works great but gives lints error.

If possible, include a link to a codesandbox with a minimal reproduction

No response

Possible fix

Make size attribute accept number also

Self-service

  • I would be willing to implement a fix for this issue
@rtivital rtivital added the Fixed patch Completed issues that will be published with next patch (1.0.X) label Jan 3, 2024
rtivital added a commit that referenced this issue Jan 3, 2024
@rtivital
[@mantine/core] Rating: Improve size type (#5470)
40290c7
@rtivital
Copy link
Member

rtivital commented Jan 9, 2024

Fixed in 7.4.1

@rtivital rtivital closed this as completed Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Fixed patch Completed issues that will be published with next patch (1.0.X)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rtivital @CripyIce