Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New dark theme colors mismatch #5480

Closed
2 tasks done
jmcmahon443 opened this issue Dec 26, 2023 · 1 comment
Closed
2 tasks done

New dark theme colors mismatch #5480

jmcmahon443 opened this issue Dec 26, 2023 · 1 comment
Labels
Fixed patch Completed issues that will be published with next patch (1.0.X)

Comments

@jmcmahon443
Copy link

jmcmahon443 commented Dec 26, 2023

Dependencies check up

  • I have verified that I use latest version of all @mantine/* packages

What version of @mantine/* packages do you have in package.json?

7.3.2

What package has an issue?

@mantine/core

What framework do you use?

Vite

In which browsers you can reproduce the issue?

All

Describe the bug

The latest default theme color scheme changes produced what appears to be an unintentional color mismatch between borders and dividers. Where mantine borders and dividers used to be the same color, now they are different colors. Specifically:

  • --_divider-color: var(--mantine-color-dark-3)
  • --_app-shell-border-color: var(--mantine-color-dark-4)

If possible, include a link to a codesandbox with a minimal reproduction

https://codesandbox.io/p/sandbox/jovial-liskov-62zl8t

Possible fix

Change mantine/packages/@mantine/core/src/components/Divider/Divider.module.css lines 10 & 14:
Line 10: Change --mantine-color-gray-4 to --mantine-color-gray-3
Line 14: Change --mantine-color-dark-3 to --mantine-color-dark-4

Self-service

  • I would be willing to implement a fix for this issue
    Tested these changes locally, and they worked. Not sure how to submit a pull request without access, need to speak to a maintainer first.
@rtivital rtivital added the Fixed patch Completed issues that will be published with next patch (1.0.X) label Jan 17, 2024
@rtivital
Copy link
Member

Fixed in 7.4.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed patch Completed issues that will be published with next patch (1.0.X)
Projects
None yet
Development

No branches or pull requests

2 participants