Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make <AppShell> and friends account for safe area insets #5502

Closed
1 of 2 tasks
odnamrataizem opened this issue Jan 3, 2024 · 1 comment
Closed
1 of 2 tasks

Make <AppShell> and friends account for safe area insets #5502

odnamrataizem opened this issue Jan 3, 2024 · 1 comment
Labels
Fixed patch Completed issues that will be published with next patch (1.0.X)

Comments

@odnamrataizem
Copy link

Dependencies check up

  • I have verified that I use latest version of all @mantine/* packages

What version of @mantine/* packages do you have in package.json?

7.3.2

What package has an issue?

@mantine/core

What framework do you use?

Other, I will specify in the bug description

In which browsers you can reproduce the issue?

Safari

Describe the bug

The <AppShell> components are not taking into account the safe area environment variables. These normally take place on PWAs. E.g., in the following iOS Safari screenshot taken from an example in Mantine docs, the footer padding should be increased by env(safe-area-inset-bottom) to avoid getting obscured by the black bar at the bottom (depending on the footer's height and contents).

IMG_A1DCA12592CB-1

If possible, include a link to a codesandbox with a minimal reproduction

https://mantine.dev/app-shell/?e=FullLayout

Possible fix

No response

Self-service

  • I would be willing to implement a fix for this issue
@rtivital rtivital added the TBD It is clear how to fix the issue and the fix will be provided soon label Jan 17, 2024
rtivital added a commit that referenced this issue Mar 26, 2024
@rtivital rtivital added Fixed patch Completed issues that will be published with next patch (1.0.X) and removed TBD It is clear how to fix the issue and the fix will be provided soon labels Mar 26, 2024
@rtivital
Copy link
Member

Fixed in 7.1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed patch Completed issues that will be published with next patch (1.0.X)
Projects
None yet
Development

No branches or pull requests

2 participants