ModalProvider: onClose causing Type Error before opening any modal

[dimbslmh]

Dependencies check up

• I have verified that I use latest version of all @mantine/* packages

What version of @mantine/* packages do you have in package.json?

7.4.1

What package has an issue?

@mantine/modals

What framework do you use?

Next.js

In which browsers you can reproduce the issue?

Chrome

Describe the bug

ModalProvider: onClose causing Type Error before opening any modal.
Esc key triggers onClose without an id.
Not sure if it's caused by trapFocus: false only.. But you'd expect onClose only to closeModal when an id is available.

mantine/packages/@mantine/modals/src/ModalsProvider.tsx

Line 211 in 703bf44

onClose={() => closeModal(state.current!.id)}

If possible, include a link to a codesandbox with a minimal reproduction

https://codesandbox.io/p/sandbox/jolly-boyd-45rsvz

Possible fix

No response

Self-service

• I would be willing to implement a fix for this issue

[rtivital]

2024-01-17.16.22.24.mov

I cannot reproduce the issue on the provided codesandbox, there is no error in the console

[dimbslmh]

2024-01-17.16.22.24.mov
I cannot reproduce the issue on the provided codesandbox, there is no error in the console

Please try again, I've changed the default trapFocus to false.

Screen.Recording.2024-01-17.at.9.36.53.PM.mov

[rtivital]

Fixed in 7.4.2