[@mantine/rte] add args for onChange callback #1268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtivital
reviewed
Apr 17, 2022
| @@ -44,10 +45,10 @@ export interface RichTextEditorProps | |||
| extends DefaultProps<RichTextEditorStylesNames>, | |||
| Omit<React.ComponentPropsWithoutRef<'div'>, 'onChange'> { | |||
| /** HTML content, value not forced as quill works in uncontrolled mode */ | |||
| value: string; | |||
| value: string | Delta; | |||
There was a problem hiding this comment.
We cannot change value type, it will be breaking. Adding types to onChange is fine.
There was a problem hiding this comment.
But this is input value. This is just extend types which you can provide to RTE component. Also, we leave string type
There was a problem hiding this comment.
Ah, yes, that's true, sorry, I was thinking of something else
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I see that there are not enough args. Can we add them?