Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[@mantine/core] Alert: a11y fixes #1269

Merged
merged 1 commit into from
Apr 17, 2022
Merged

[@mantine/core] Alert: a11y fixes #1269

merged 1 commit into from
Apr 17, 2022

Conversation

apoco
Copy link
Contributor

@apoco apoco commented Apr 16, 2022 •
edited

  • Add alert role to Alert components
  • Use the title to label alerts
  • Use the body to describe alerts

@apoco apoco marked this pull request as draft April 17, 2022 00:02
@apoco
[@mantine/core] Alert: a11y fixes
c800f82 
- Add `alert` role to `Alert` components
- Use the title to label alerts
- Use the body to describe the alert
@apoco apoco marked this pull request as ready for review April 17, 2022 00:09
@rtivital rtivital merged commit 92ac63e into mantinedev:master Apr 17, 2022
@rtivital
Copy link
Member

Thanks!

@apoco apoco deleted the alert-role branch April 17, 2022 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@apoco @rtivital