Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@mantine/core] NumberInput: Allows the "-" symbol in an empty NumberInput #1445

Merged
merged 1 commit into from
May 12, 2022
Merged

[@mantine/core] NumberInput: Allows the "-" symbol in an empty NumberInput #1445

merged 1 commit into from
May 12, 2022

Conversation

BWsix
Copy link
Contributor

@BWsix BWsix commented May 12, 2022

Fixes the bug in NumberInput raised in the discord bugs channel

Is NumberInput not allowing the "-" symbol in an empty NumberInput expected behavior? Currently, you are unable to type "-" in an empty NumberInput unless you first put a number then go back and place the "-" before it

Changes:

  • You can now type - in an empty NumberInput.
  • If - is the only thing in a NumberInput, the value will remain undefined, and the NumberInput will be cleared when the onBlur event fires.

@rtivital rtivital merged commit 158c9cb into mantinedev:master May 12, 2022
@rtivital
Copy link
Member

Thanks!

@BWsix BWsix deleted the patch-number-input branch May 12, 2022 14:05
@coolRoger
Copy link

@rtivital great job, and when are you going to release this bug fixed to npm?

@rtivital
Copy link
Member

Patches are usually released every Sunday

@mattrunyon mattrunyon mentioned this pull request May 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants