Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[@mantine/styles] sx: Add undefined for array #1447

Merged
merged 1 commit into from
May 12, 2022
Merged

[@mantine/styles] sx: Add undefined for array #1447

merged 1 commit into from
May 12, 2022

Conversation

AzzouQ
Copy link
Contributor

@AzzouQ AzzouQ commented May 12, 2022

With strictMode, TS will give an error following this use case: https://mantine.dev/theming/sx/#sx-array

This PR add undefined to sx array's definition.

@AzzouQ
Copy link
Contributor Author

AzzouQ commented May 12, 2022

Forked from dev instead of master on #1446, fixed it, sorry

@AzzouQ AzzouQ changed the title [@mantine/styles] sx: Add undefined for array [@mantine/styles] sx: Add undefined for array May 12, 2022
@rtivital rtivital merged commit cd99378 into mantinedev:master May 12, 2022
@rtivital
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AzzouQ @rtivital