Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@mantine/hooks] use-did-update: Optimize fast refresh #1870

Merged
merged 3 commits into from
Aug 16, 2022

Conversation

u3u
Copy link
Contributor

@u3u u3u commented Jul 26, 2022

No description provided.

@rtivital
Copy link
Member

Why are these changes required?

@u3u
Copy link
Contributor Author

u3u commented Jul 26, 2022

At development time HMR will uninstall the component, but mounted is not reset, after that every save refresh will trigger useDidUpdate, sorry I didn't pay attention to ESLint

@rtivital
Copy link
Member

@u3u can you please fix tests errors?

@u3u
Copy link
Contributor Author

u3u commented Aug 13, 2022

Of course, I've fixed it.

@rtivital rtivital changed the base branch from master to dev August 16, 2022 12:27
@rtivital rtivital merged commit 486bd30 into mantinedev:dev Aug 16, 2022
@rtivital
Copy link
Member

Thanks!

@u3u u3u deleted the fix/use-did-update branch August 17, 2022 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants